shokri-navid / OCM-1.1

0 stars 0 forks source link

update frontend of files application to show the INVITATION_LINK result in sharees drop down. #4

Open shokri-navid opened 2 weeks ago

shokri-navid commented 2 weeks ago

It seems that I should Update this file:

apps/files_sharing/src/views/SharingTab.vue

shokri-navid commented 2 weeks ago

:information_source:

So I found two files: /workspaces/dev-stock/ocm-nextcloud1/node_modules/@nextcloud/sharing/dist/index.d.ts

And

/workspaces/dev-stock/ocm-nextcloud1/apps/files_sharing/src/views/shares.ts

those have essential codes about share types but the first one is inside node modules and I guess It could not be updated. I should find the main file :confused:

shokri-navid commented 1 week ago

I had some progress and currently, my changes reflect on the running instance but it seems I should add an Invitation link to this file:

nod_modules/@nextcloud/sharing/index.d.ts

but obviously, it is a node module and I should find a repository to change the main code.

shokri-navid commented 6 days ago

NPM page of the mentioned package:

https://www.npmjs.com/package/@nextcloud/sharing

:information_source: this is the module repository:

https://github.com/nextcloud-libraries/nextcloud-sharing/blob/main/lib/index.ts

shokri-navid commented 6 days ago

https://github.com/nextcloud/server/blob/master/apps/files_sharing/src/mixins/ShareTypes.js as it is clear it is using a @nextcloud/sharing npm package to register all share types and this is the code of the package:

https://github.com/nextcloud-libraries/nextcloud-sharing/blob/main/lib/index.ts

and according to this part of the code:

https://github.com/nextcloud/server/blob/4176708797c019ff4d87f7ea49c915232fb95b1a/apps/files_sharing/src/components/SharingInput.vue#L171

const shareType should contain value 14. but according to this image it is seen as undefined: :thinking:

image image

shokri-navid commented 6 days ago

I cloned the this repo perform my changes and replaced the build result in nod_modules and the result is:

image