search

sholladay / pogo

Server framework for Deno
Mozilla Public License 2.0
482 stars 33 forks source link

Update to Deno 0.42.0 and std 0.50.0 #27

Closed patlehmann1 closed 4 years ago

patlehmann1 commented 4 years ago

This PR addresses the errors experienced on startup relating to using std version 0.41.0 with the latest version of deno, v1.0.0-rc1. Upgrading std to version 0.50.0 resolved this issue. These changes were smoke tested locally with a "hello, world" example. Closes #26

sholladay commented 4 years ago

Great, thanks. Could you also update the note towards the top of the README?

sholladay commented 4 years ago

Looks like they removed Deno.EOF in Deno 0.42.0. Need to update the reference to that in the README as well.

Lastly, the version in the Travis CI config needs to be updated.

patlehmann1 commented 4 years ago

@sholladay I wasn't sure if I should have updated the travis config file to v0.42.0 or v1.0.0-rc1. Either way, the issue has been resolved.

sholladay commented 4 years ago

I would have been fine with either. I'm going to merge as-is, with CI testing Deno 0.42.0. Thanks again!

Ideally, I would like CI to test multiple Deno versions. Should be able to do that pretty easily with a Travis CI build matrix. I haven't really looked into it yet, but PR welcome for anyone who has time.