search

sholladay / pogo

Server framework for Deno
Mozilla Public License 2.0
482 stars 32 forks source link

Add React on Client example #39

Closed venikman closed 1 year ago

venikman commented 4 years ago

Part of #19

danrasmuson commented 2 years ago

It be lovely to merge this PR. Is it blocked by anything? Can I help?

sholladay commented 2 years ago

@danrasmuson agreed, let's get this fixed up and merged. At the moment, this example doesn't actually work because it requires a build step, which isn't accounted for.

We need to either: A. Build the app and commit the app.js file to the git repo. That would make it easier for people to run the example, but then app.js has to be kept in sync with changes to the source and it bloats the git repo because it will include all of React. B. Update the example's instructions to include the build step. I think I'd prefer this approach, but I'm open to alternatives.

Assuming we go with B, then we should consider how the user will actually run the build. Should the instructions have the user run the mkdir -p build and deno bundle commands or should they just have something like sh -c "$(curl -fsSL https://raw.githubusercontent.com/sholladay/pogo/master/react-on-client/build.sh)";? I'm leaning towards the former. The latter could be a standard across all future examples that may need a build step, which would be nice, but some people might be afraid of running a remote shell script like that. There may be other alternatives I haven't considered.

danrasmuson commented 2 years ago

Okay. Lovely. I have time on Wednesday to give it a go.

danrasmuson commented 2 years ago

@sholladay I followed your directions as I understood them and put a PR #69

sholladay commented 1 year ago

Closing in favor of #69, which contains the commits from this PR (meaning you'll still get credit).