Closed afaur closed 4 years ago
As for mod.ts vs main.ts - yeah, I went against the Deno community's convention on naming this file...
- I removed the
mod.ts
files sincemain.ts
is the public entry point for pogo.I'm relatively new to TypeScript and still trying to get a good feel for what should be public vs private.
- Initially I thought it would be good to expose everything, but now changed it to what the user should know about.
- I wasn't able to get
Request
andResponse
exposed in a way fordeno doc
to annotate them.- I think this might be possible, but may require an
interface
for them that gets added totypes.ts
?I'm willing to have a mod.ts alias for people who expect it or tools that make assumptions about it
- The
mod.ts
probably comes from themod.rs
in rust.
Should add in a follow up PR:
deno doc
badge to the top of the readme
jsdoc
strings at the top of exported items.Sorry about the merge conflicts. I moved some things around while implementing h.directory()
. If you could fix the conflict and remove the toolkit interface, in favor of exposing the class like you had it earlier, this will be ready to merge.
No problem. I was able to merge master into this today, and the changes were easy to resolve.
I removed the interfaces that I added to types
, and then added tookit
, request
, and response
as exports from main.
I think this will allow for jsdoc
strings on everything that is currently listed here (https://github.com/sholladay/pogo#api).
This is looking great. I'll try it out when I get to a terminal. Aiming to merge this tonight.
deno doc
command.mod.ts
inlib/util
simplifiesmain.ts
andmod.ts
by making them not change if files get added toutil
.mod.ts
inlib
allowsmain.ts
andmod.ts
to have less duplication.main.ts
should be removed fromroot
directory to usemod.ts
as other Deno projects seem to do?main.ts
andmod.ts
in the root directory are exactly the same right now.Main
object that containsserver
androuter
?Update:
lib/mod.ts
tolib/main.ts
mod
here.main.ts
and fixtests
mod.ts
in the root to a one line exportdeno doc
stops showing the main entry point from the output with this change.server
androuter
functions.deno doc
.