search

sholladay / pogo

Server framework for Deno
Mozilla Public License 2.0
482 stars 32 forks source link

Update dependencies.ts #50

Closed khrome83 closed 4 years ago

khrome83 commented 4 years ago

Closes #49

You can validate that the pika URL was causing the issue by running deno cache -r https://cdn.pika.dev/react@16.13.1.

This produced the thread panic error.

thread 'main' panicked at 'url redirection should provide 'location' header', cli/http_util.rs:141:29
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Switching to the skypack.dev dependency fixes this issue. I did not modify any other pika.dev routes, since it does not seem to be consistent for all.

khrome83 commented 4 years ago

I can not validate if this fixes the issue, as it causes a new problem.

error: TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
        <html>
        ~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:12:9

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
            <body>
            ~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:13:13

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                <h1>Directory: {'/' + basePath}</h1>
                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:14:17

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                <h1>Directory: {'/' + basePath}</h1>
                                               ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:14:48

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                <table>
                ~~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:15:17

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                    <thead>
                    ~~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:16:21

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                        <tr>
                        ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:17:25

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Type</th>
                            ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:18:29

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Type</th>
                                    ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:18:37

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Name</th>
                            ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:19:29

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Name</th>
                                    ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:19:37

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Size</th>
                            ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:20:29

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Size</th>
                                    ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:20:37

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Created</th>
                            ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:21:29

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Created</th>
                                       ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:21:40

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Modified</th>
                            ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:22:29

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <th>Modified</th>
                                        ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:22:41

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                        </tr>
                        ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:23:25

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                    </thead>
                    ~~~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:24:21

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <tr>
                            ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:27:29

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>📂</td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:28:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>📂</td>
                                      ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:28:39

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td><a href="..">Parent Directory (..)</a></td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:29:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td><a href="..">Parent Directory (..)</a></td>
                                    ~~~~~~~~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:29:37

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td><a href="..">Parent Directory (..)</a></td>
                                                                      ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:29:71

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td><a href="..">Parent Directory (..)</a></td>
                                                                          ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:29:75

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>-</td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:30:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>-</td>
                                     ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:30:38

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>-</td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:31:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>-</td>
                                     ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:31:38

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>-</td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:32:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>-</td>
                                     ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:32:38

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            </tr>
                            ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:33:29

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            <tr key={file.name}>
                            ~~~~~~~~~~~~~~~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:44:29

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>{file.isDirectory ? '📁' : '📝'}</td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:45:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>{file.isDirectory ? '📁' : '📝'}</td>
                                                                    ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:45:69

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td><a href={file.name + (file.isDirectory ? '/' : '')}>{file.name}</a></td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:46:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td><a href={file.name + (file.isDirectory ? '/' : '')}>{file.name}</a></td>
                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:46:37

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td><a href={file.name + (file.isDirectory ? '/' : '')}>{file.name}</a></td>
                                                                                                   ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:46:100

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td><a href={file.name + (file.isDirectory ? '/' : '')}>{file.name}</a></td>
                                                                                                       ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:46:104

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>{file.isDirectory ? '-' : `${file.size} bytes`}</td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:47:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>{file.isDirectory ? '-' : `${file.size} bytes`}</td>
                                                                                   ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:47:84

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>{file.birthtime?.toLocaleDateString()}</td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:48:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>{file.birthtime?.toLocaleDateString()}</td>
                                                                          ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:48:75

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>{file.mtime?.toLocaleDateString()}</td>
                                ~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:49:33

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                                <td>{file.mtime?.toLocaleDateString()}</td>
                                                                      ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:49:71

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                            </tr>
                            ~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:50:29

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
                </table>
                ~~~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:53:17

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
            </body>
            ~~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:54:13

TS7026 [ERROR]: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
        </html>
        ~~~~~~~
    at https://raw.githubusercontent.com/khrome83/pogo/master/lib/components/directory-listing.tsx:55:9

Found 50 errors.
khrome83 commented 4 years ago

Running with --no-check now causes this issue in Deno 1.3.1


thread 'main' panicked at 'internal error: entered unreachable code: invalid pattern: Span { lo: BytePos(311), hi: BytePos(366), ctxt: #0 }', /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/macros.rs:16:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
sholladay commented 4 years ago

Ugh. That's so annoying, thanks for the PR. I think the best solution may be to revert https://github.com/sholladay/pogo/commit/e5cc45c0a1fb945d336ebb2ea2c9f5e70d1271b8. Multiple times now I've changed Pogo to use Pika when I see it's working well and then some new issue comes up. It's so unstable.

khrome83 commented 4 years ago

Can you try pulling the PR and run with -r and see if it resolves it @sholladay .

I switched to the same sources that were reverted, and am getting the same issues as above.

thread 'main' panicked at 'internal error: entered unreachable code: invalid pattern: Span { lo: BytePos(311), hi: BytePos(366), ctxt: #0 }', /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/macros.rs:16:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
sholladay commented 4 years ago

I fixed this separately on master in https://github.com/sholladay/pogo/commit/64ef11371480e32eb8323ddbe3ad46781d1d75ea. Should've pushed it to this PR first... oops.

Turned out to be a little tricky to fully debug and fix due to https://github.com/denoland/deno/issues/7380 and the deno_types repo recommending denopkg.com, which doesn't actually work because of that Deno bug.

Thanks for the useful bug report and getting the ball rolling on this!