search

shombando / EmacsVanillaChocolateSwirl

Minimal config for Emacs to flatten the learning curve for transitioning users
Apache License 2.0
12 stars 4 forks source link

Rewrite package configuration description and add iBuffer as default #5

Closed systemhalted closed 4 years ago

systemhalted commented 4 years ago

@shombando

systemhalted commented 4 years ago

I should have probably created two PRs - one for iBuffer and other for small rewrite. If you like that way, I can separate them.

shombando commented 4 years ago

@systemhalted thanks for adding additional config to make life easier. Can you please rephrase your ibuffer section to be more informative? We want the description to be about ibuffer itself and why it may be more useful than the default buffer manager but we don't want to bash choices made by the emacs maintainers. This will educate the user and let them choose if that's what they want to do. The goal is provide options not indoctrinate but I do admire your passion!

Also, it may be better to do separate pull requests as you're making these changes. If I could request you be mindful for copying and pasting sections since that messes with the git history (diff should be able to recognize things just moved but if often can't and then git blame breaks over time). Basically if we don't intend to modify a section it shouldn't show up in a diff.

By the way, I'm trying to do things as legit as possible so if you'd rather just contribute config and not mess with idiomatic git usage, that's totally fine too... I'll just cherry pick, but if you want to practice best practices I can continue providing feedback like above. Please let me know what you prefer and thanks for the interest.