search

shon-otmazgin / fastcoref

MIT License
142 stars 25 forks source link

allow existing language argument when creating CorefModel #31

Closed aryehgigi closed 1 year ago

aryehgigi commented 1 year ago

fixes #30

shon-otmazgin commented 1 year ago

Thanks @aryehgigi

it failed beacuse nlp was a spacy model instead of str here -> self.nlp = spacy.load(nlp.. ?

aryehgigi commented 1 year ago

yes. and then again at download(nlp) inside the catch block (this catch block is intended to catch the case where the str given is of a model that wasnt downloaded before - not for an nlp object (spacy.Language type) case)