shon-otmazgin / fastcoref

MIT License
142 stars 25 forks source link

BUG: spacy_component not working #51

Open alex2awesome opened 7 months ago

alex2awesome commented 7 months ago

Hi, I'm realy not sure why this fails, but in rare cases the spacy_component will fail here:

    if coref != mention and not self._is_containing_other_spans(coref, all_spans):
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home1/spangher/miniconda3/lib/python3.11/site-packages/fastcoref/spacy_component/spacy_component.py", line 83, in _is_containing_other_spans
    return any([s[0] >= span[0] and s[1] <= span[1] and s != span for s in all_spans])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home1/spangher/miniconda3/lib/python3.11/site-packages/fastcoref/spacy_component/spacy_component.py", line 83, in <listcomp>
    return any([s[0] >= span[0] and s[1] <= span[1] and s != span for s in all_spans])
                ~^^^
TypeError: 'NoneType' object is not subscriptable
"""

I tried truncating the data to be < 4096 tokens but that didn't solve it.

Below is a text where the issue occurs. It seems to only occur when I'm doing a pipeline, I can't replicate it in a normal setting.

We use cookies and other tracking technologies to improve your browsing experience on our site, show personalized content and targeted ads, analyze site traffic, and understand where our audience is coming from. To find out more or to opt-out, please read our Cookie Policy. By choosing I Accept, you consent to our use of cookies and other tracking technologies. Airbnb's CFO is leaving after clashing with CEO Brian Chesky The fast-growing travel company has also elevated its exec Belinda Johnson to the COO role. Airbnb is overhauling its executive ranks, the company announced on Thursday, parting ways with its chief financial officer, who many thought would someday shepherd the company through an IPO, and elevating a senior executive into the chief operating officer role -- the No. Laurence Tosi, a Wall Street veteran who had held the CFO role since 2015, is departing the company "to dedicate his full time and energy to his investment fund, Weston Capital Partners." According to a recent report in The Information, Tosi and CEO Brian Chesky had clashed over "how to balance the financial stability needed to go public with Mr. Chesky's desire to transform Airbnb into a more diversified travel firm, investing in areas that might not yield profits for awhile." A person familiar with the relationship told Recode that the two had "different philosophies" over how Airbnb should grow. Airbnb also announced the promotion of Belinda Johnson, previously the company's chief business affairs and legal officer, to the No. 2 role of chief operating officer. She'll add the oversight of the trust and safety, customer service and payments teams to her existing responsibilities. In a blog post, Chesky said: "As our COO, Belinda will be responsible for the systems and teams that enable our businesses to function, as well as our legal, policy and communications teams. Belinda and I often approach things differently, and this is one of the reasons we've worked so well together over the years. I learn from her every day, and I'm a better leader because she is my partner." The changes come at a critical time for Airbnb, which now does billions of dollars in annual revenue and is seen as a sure-shot IPO candidate one day. In the blog post, the company said it is now profitable on an Ebitda basis with more than $5 billion on its balance sheet. Chesky said the company's IPO will not happen this year. The in-depth Information report, which is worth a full read, said that Tosi had been gunning to take on more power at the company, either through a COO designation or by being named president of the company's core Homes division. Airbnb's head of financial planning and analysis, Ellie Mertz, will serve as the finance chief on an interim basis while the executive search firm Crist Kolder Associates helps Airbnb hire a new CFO. Sign up for the newsletter Recode Daily Email (required) By signing up, you agree to our Privacy Policy and European users agree to the data transfer policy. This article originally appeared on Recode.net. Milo Yiannopoulos and his right-wing peers seemed state of the art in 2016. CNN's Oliver Darcy talks about what changed since then. How San Francisco billionaire Tom Steyer, the richest Democratic candidate, spends his money The Democratic presidential candidate appears on pace to fulfill the Giving Pledge. Jack Dorsey's hack encapsulates Twitter's struggle with problematic content Dorsey himself has tried to be something of a model Twitter user. Uber and Lyft just lost another battle in California Silicon Valley can't seem to escape California's crackdown on the gig economy. Listen to our new podcast with never-before-told stories about Amazon's ascent More in The Latest Sign up for the newsletter Recode Daily Email (required) By signing up, you agree to our Privacy Policy and European users agree to the data transfer policy.