Closed shon-otmazgin closed 1 year ago
I changed device parameter to follow your guidelines as using the None default value but forgot to change the type requirements on it as it was intended as a string parameter. Sorry, it should have been included in the tests for the component. Just removing the type requirement from device parameter provided to init function solves the issue.
class FastCorefResolver:
#a class that implements the logic from https://towardsdatascience.com/how-to-make-an-effective-coreference-resolution-model-55875d2b5f19
def __init__(
self,
nlp,
name,
model_architecture: str,
model_path:str,
device,
max_tokens_in_batch: int
):
fixed! thanks !
@mlostar I can see a BUG while running:
seems like the default values are not been fulfiled