search

shon / httpagentparser

Python HTTP Agent Parser
http://pypi.python.org/pypi/httpagentparser/
MIT License
220 stars 55 forks source link

Netscape broke Chrome recognition #15

Open andrewshkovskii opened 12 years ago

andrewshkovskii commented 12 years ago

For strings like :
Netscape(5.0 (Windows NT 6.1) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/14.0.835.186 Safari/535.1) Netscape(5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/8.0.552.237 Safari/534.10) Netscape(5.0 (Windows NT 6.1) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/14.0.835.186 Safari/535.1) Netscape(5.0 (Windows NT 6.1) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.112 Safari/535.1) Netscape(5.0 (Windows NT 6.1) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.112 Safari/535.1) Netscape(5.0 (Windows NT 6.1) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.112 Safari/535.1)

Simple_parse returning : Netscape ... Fix Netscape recognition like this :

class Netscape(Browser): look_for = "Netscape"

--- if find 'Chrome' - browser type = 'Chrome' ---

def checkWords(self, agent):
    unless_list = ["Chrome"]
    if self.look_for in agent:
        for word in unless_list:
            if word in agent:
                return False
        return True
shon commented 12 years ago

Possible to send a patch? Really busy at this moment.