shonny-ua / gulp-rev-collector

Static asset revision data collector from manifests, with was generated from different streams and replace they's links in html template.
MIT License
150 stars 41 forks source link

Sorts change regexes by pattern length before applying #14

Closed ebakan closed 9 years ago

ebakan commented 9 years ago

This ensures that patterns which are supersets of other patterns get applied first.

For example, with the following manifest.json:

{
  "src.js":"src-1234abc.js",
  "src.js.map":"src-abc1234.js.map"
}

If src-1234abc.js has the comment //# sourceMappingURL=src.js.map, we would want to replace it with src-abc1234.js.map, not src-1234abc.js.map, as the current implementation does.

shonny-ua commented 9 years ago

Use version 1.0.1 and have fun! ;)

ebakan commented 9 years ago

Thanks! Though I ran into https://github.com/shonny-ua/gulp-rev-collector/issues/15