search

shonny-ua / gulp-rev-collector

Static asset revision data collector from manifests, with was generated from different streams and replace they's links in html template.
MIT License
150 stars 41 forks source link

Breaks for multi-constant concatenation? #23

Closed momoadeli closed 7 years ago

momoadeli commented 8 years ago

rev-collector fails when I use two constants to build an image path to 'testdefault.png' (testdefault-XXXXXXX.png is NOT created):

`URLS = { IMAGE_PREFIX:"", IMAGE_BASE_LOCAL_CAST_BANNERS:"img/banners"}

DEFAULT_IMAGE = { TEST: {TESTDEFAULT:cf.URLS.IMAGE_PREFIX + URLS.IMAGE_BASE_LOCAL_CAST_BANNERS+ "/testdefault.png" } ` However, once I remove the second constant and define the path a little more explicitly, rev-collect works (testdefault-XXXXXXX.png is created):

DEFAULT_IMAGE = { TEST: { TESTDEFAULT:cf.URLS.IMAGE_PREFIX + "img/banners/testdefault.png" } ` manifest is correct: "img/banners/testdefault.png": "img/banners/testdefault-13626465c2.png"

Please advise.

Many Thanks!

shonny-ua commented 8 years ago

Hmmm... The rev-collector don't generate any manifest files. It's work for gulp-rev.

This module collect different generated manifests, and makes necessary replacements in html template.