shonny-ua / gulp-rev-collector

Static asset revision data collector from manifests, with was generated from different streams and replace they's links in html template.
MIT License
150 stars 41 forks source link

when I modified the rev_manifest.json .. #30

Closed trickyEdecay closed 7 years ago

trickyEdecay commented 7 years ago

I used some methods to modify the rev_manifest.json after use gulp-rev

and now , my rev_manifest.json looks like this:

{
  "assets/less/common.less": "assets/css/common-2c0d21e40c.css"
}

It means that they have different ext : less & css

and I found that was cause by the index.js on line 31

if ( !_.isString(json[key]) || path.basename(json[key]).replace(new RegExp( opts.revSuffix ), '' ) !==  path.basename(key) ) {

could u delete the second condition for this issue? or there may cause more issues?

shonny-ua commented 7 years ago

Use version 1.2.0