gulp-rev-collector fails to recognize `.js.map` entries, and rejects therefore the entire `rev-manifest.json`

shonny-ua / gulp-rev-collector

Static asset revision data collector from manifests, with was generated from different streams and replace they's links in html template.

MIT License

150 stars 41 forks source link

gulp-rev-collector fails to recognize `.js.map` entries, and rejects therefore the entire `rev-manifest.json` #33

Closed Ocramius closed 7 years ago

Ocramius commented 7 years ago

This condition will fail to recognize a rev-manifest.json such as following:

{
    "js/app.js": "js/app-aaaaaaaaaa.js",
    "maps/js/app.js.map": "maps/js/app-aaaaaaaaaa.js.map"
}

The reason is the last conditional, which will compare app.js.map and app.js (path.basename('app-aaaaaaaaaa.js.map') is 'app-aaaaaaaaaa.js'

Writing a test as I'm reporting this.

shonny-ua commented 7 years ago

This test passed.On a linux system. It's only windows problem?

Ocramius commented 7 years ago

@shonny-ua the setup is more complex, as it's a mix of vagrant/windows/linux.

As far as I'm concerned, since I'm no longer working on that project, and no longer have access to that specific environment, this is an unsolved issue, but I won't be able to look further into it.

To people getting to this issue after a lot of searching, I can only suggest to get a proper dev/prod environment, and stop building stuff on windows: you are actively hurting yourselves.

The resolution of this issue is incomplete.