Adding test to verify #33 - when a file in a revision map has more than one extension, the revision map is considered invalid

shonny-ua / gulp-rev-collector

Static asset revision data collector from manifests, with was generated from different streams and replace they's links in html template.

MIT License

150 stars 41 forks source link

Adding test to verify #33 - when a file in a revision map has more than one extension, the revision map is considered invalid #34

Closed Ocramius closed 7 years ago

Ocramius commented 7 years ago

Tests for #33

Didn't yet test locally, because I really don't wanna install NodeJS on my personal computer :-D

I'll hope for travis, or else will try going with node-docker.

Ocramius commented 7 years ago

This doesn't seem to fail in the test suite... weird :-\

Given a path /something/something/rev-manifest.json, I am seeing path.basename("maps/js/app.js.map") producing an output of app.js.

This is on NodeJS 7.9 on a Windows machine, so I'm starting to think that path.basename() behaves differently depending on environment. Sigh, windows again...