search

shonumi / gbe-plus

DMG/GBC/GBA emulator and experimental NDS emulator.
GNU General Public License v2.0
524 stars 79 forks source link

Sewing inaccuracy in Kirby Family #121

Closed Kilicool64 closed 2 years ago

Kilicool64 commented 2 years ago

I don't know if you're willing to look into this, given that this is an issue with a leaked game (don't know if it also happens somewhere in any of the sewing machine games that actually got released), but I tested some of the sewing patterns in Kirby Family. While most of them seem fine (there are some stray pixels, but it's possible the patterns simply aren't that accurate), there's one where something clearly goes wrong. Here's the full picture along with just the part that doesn't get "sewn" correctly. The sewing machine simulation first correctly "sews" Kirby's left shoe and mouth, but then it "sews" the right shoe without repositioning itself first. 223793994124969860 2637245331946508462

shonumi commented 2 years ago

Hmm... The last time I and another user tested that exact same pattern it came out just fine. I'll take another look, since I do know there is another issue with some of the kanji embroidery patterns in one of the other titles.

About the stray pixels, the original embroidery patterns don't translate 1:1 to real pixels. It's close in most cases, but it's intended to be a bit "fuzzy" since a real machine uses threads. To remedy this, try changing the thickness to 2x. This produces more consistent looking patterns.

shonumi commented 2 years ago

Okay, just a small update. The Kirby pattern works just fine with Patterns 1 and 3 on Kirby Family, but Pattern 2 is problematic, as you describe. They all look alike, so that's what confused me initially.

Good news is that this is the same issue I mentioned earlier with the kanji embroidery. I actually did fix it some time last year, but never committed it, so I guess it's time to actually do that now.

Kilicool64 commented 2 years ago

Ah, sorry. Forgot to mention it was Pattern 2. Yeah, the first three patterns are just the same image in different sizes, so they're easy to mix up.

I assume that a new release with this issue fixed won't happen until April, right? Bit inconvenient for me since I lack the technical know-how to compile this software myself, but I guess I can wait. I'm only using it since I was curious to see if Kirby Family works.

Kilicool64 commented 2 years ago

Given that this issue is still open and hasn't been mentioned in the latest release notes, I take it you didn't get around to committing your fix yet?

shonumi commented 2 years ago

No, it was fixed quite a while ago, back in November -> beaa59467fa0745e17a588d7858a4ca658510587

I thought I'd closed this, but I guess I forgot to. Anyway, it's fixed in 1.6.