shooking / ZoomPedalFun

A collection of tips and tricks for Zoom B1On, B1XFour and G1XFour pedals.
Creative Commons Zero v1.0 Universal
60 stars 2 forks source link

Script exiting before finishing #16

Open Colatino opened 2 years ago

Colatino commented 2 years ago

I've been running your zoomzt2-shooking script to get the files (zt2, bmp, json) of all of the fx available for the G1X Four but when it encounters one that is not installed it exits without trying the others. Don't know if it is a bug or a feature.

For my purpose I changed the getfile method to the following:

    def getfile(self, name):
        logging.info("options.receive - getting {}".format(name))
        state = self.file_check(name)
        if (state == False):
#             self.disconnect()
#             sys.exit("Filename doesnt exist")            
            return False

And inside options.receive i've included an if condition:

currFX = pedal.getfile(dict(effect)["effect"])
if currFX:
    total_pedal.append(currFX)
    fxLookup[myID, myGID] = j 
    j = j + 1

This way it seems to run through all of the installed fx and skip the ones not installed. I didn't check for any new issues caused by this change.

Colatino commented 2 years ago

Also, I just uploaded all of the effects available for the G1X-Four (the ones available on Tonelib/Guitarlab) to a repo here on github https://github.com/Colatino/G1X-Four. I used your script to exctract them.

shooking commented 2 years ago

Good spot. I dont understand how the extract cannot find the FX (after all it looks at the current state of the pedal). I can add you to the git so you can contribute directly. Bit late here now. Remind me if I haven't don't it by early next week.

Colatino commented 2 years ago

Hey @shooking, I've been working on the pedal controller for a while and I managed to build somethin usable. It's currently not using a microcontroller but a raspberry pi zero. The project is here and I uploaded a demo video to youtube here

I've used lots of your's and @mungewell 's code

mungewell commented 2 years ago

@Colatino

Nice Job. You should definitely share this over at: https://www.reddit.com/r/zoommultistomp/

There a people there who be very interested in building this.