shop-pddl-module / warns-check.lisp dependency missing

[matthewdehaven]

The shop-pddl-tests component of the homer/test system depends on the warns check added by tests/warns-check.lisp loaded in the shop-internal-tests. However, there is no explicit dependency between the shop-pddl-tests and shop-internal-tests components ensuring the warns check is available when shop-pddl-tests is compiled.

The lack of explicit dependency between shop-pddl-tests and the test/warns-check.lisp file does not seem to cause any issue most of the time. However, while using ECL version 16.1.2 with ASDF version 3.1.5.4, an error is sometimes signaled when compiling the shop3/test system.

;;; Error:
;;;   in file pddl-tests.lisp, position 64595
;;;   at (DEFPACKAGE SHOP3-ROVERS-TEST ...)
;;;   * The form (SI::DODEFPACKAGE "SHOP3-ROVERS-TEST" 'NIL NIL '("COMMON-LISP" "SHOP3") 'NIL '("COMMUNICATED_IMAGE_DATA" "COMMUNICATED_ROCK_DATA" "COMMUNICATED_SOIL_DATA" "COMMUNICATE_IMAGE_DATA" "COMMUNICATE_ROCK_DATA" "COMMUNICATE_SOIL_DATA") 'NIL 'NIL '(("SHOP3" "PDDL-METHOD-NAME-CHECKS" "NON-UNIQUE-METHOD-NAME-ERROR" "NON-UNIQUE-METHOD-NAME-WARNING") ("FIVEAM" "TEST" "DEF-FIXTURE" "IS-TRUE" "IS-FALSE" "WITH-FIXTURE" "SIGNALS" "WARNS")) 'NIL) was not evaluated successfully.
;;; Error detected:
;;; Cannot find symbol "WARNS" in package #<"IT.BESE.FIVEAM" package>
Condition of type: COMPILE-FILE-ERROR
COMPILE-FILE-ERROR while compiling #<cl-source-file "shop3/test" "shop-pddl-tests" "pddl-tests">

[matthewdehaven]

Closing issue. #139 is merged and resolves this issue.