Closed matthewdehaven closed 1 year ago
The version of fiveam
that is included as SHOP submodule has fiveam:warns
defined already. I have a suggestion for a minor refinement that I will post in the review.
@matthewdehaven Checking master
to see why the tests are failing here. Merge to come soon, promise!
Interesting: SBCL passes on master
but fails on this branch. Investigating.
I have found what's wrong. Somehow the call to warns
is not returning the value of the enclosed form, as it should. I will see if I can figure out why.
By moving warns-check.lisp into the shop-test-helper component, then adding a depends-on to shop-pddl-tests for that module. The other component which was depending on the warns-check, shop-internal-tests, already depends on the shop-test-helper component.
Addresses #138