search

shop-planner / shop3

SHOP3 Git repository
https://shop-planner.github.io
144 stars 14 forks source link

Add explicit dependency between shop-pddl-tests and warns-check.lisp #139

Closed matthewdehaven closed 1 year ago

matthewdehaven commented 1 year ago

By moving warns-check.lisp into the shop-test-helper component, then adding a depends-on to shop-pddl-tests for that module. The other component which was depending on the warns-check, shop-internal-tests, already depends on the shop-test-helper component.

Addresses #138

rpgoldman commented 1 year ago

The version of fiveam that is included as SHOP submodule has fiveam:warns defined already. I have a suggestion for a minor refinement that I will post in the review.

rpgoldman commented 1 year ago

@matthewdehaven Checking master to see why the tests are failing here. Merge to come soon, promise!

rpgoldman commented 1 year ago

Interesting: SBCL passes on master but fails on this branch. Investigating.

rpgoldman commented 1 year ago

I have found what's wrong. Somehow the call to warns is not returning the value of the enclosed form, as it should. I will see if I can figure out why.