search

shop-planner / shop3

SHOP3 Git repository
https://shop-planner.github.io
147 stars 14 forks source link

Check on style warning in test #17

Open rpgoldman opened 5 years ago

rpgoldman commented 5 years ago

Running the tests on SBCL, I see this in the transcript:

 Running test METHOD-TESTS ..
WARNING: Condition STYLE-WARNING was signalled.

not yet sure what causes this, and the test still passes.

rpgoldman commented 5 years ago

Also there are style warnings in TEST-FLAW-DETECTION, I believe.

lispm commented 5 years ago

Style warnings, are just warnings. Not errors.

For example in the source code are lambda lists with &optional and &key. Example: (sexp &optional (stream t) &key (canonical nil)). There are other examples. The compiler tells the developer of a programming construct that represents what is thought to be bad programming style.

These kind of lambda lists are thought to be error-prone for programmers. They may forget to provide the optional argument when providing the keyword args. That's why there is a style warning.

SBCL also warns of uses of deprecated functions. In the code there is a call to sb-debug:backtrace. The compiler recommends to use sb-debug:print-backtrace instead.