Fix carrierwave.rb: use correct AWS var name

shopinvader / docker-locomotive-shopinvader

Run your ShopInvader server in docker !

4 stars 14 forks source link

Fix carrierwave.rb: use correct AWS var name #20

Closed simahawk closed 4 years ago

simahawk commented 4 years ago

I've tried deploying w/ a custom endpoint and I got this error:

/usr/src/app/config/initializers/carrierwave.rb:24:inblock in <top (required)>': uninitialized constant AWS (NameError)`

as per https://stackoverflow.com/questions/22826432/error-uninitialized-constant-aws-nameerror seems the AWS var name changed and we are using sdk3 already.

simahawk commented 4 years ago

hmm something is still broken. I get:

02 2019-12-09T08:53:01.186060000Z /usr/src/app/config/initializers/carrierwave.rb:26:in `block in <top (required)>': wrong number of arguments (given 1, expected 0) (ArgumentError)

02 2019-12-09T08:53:01.186616000Z   from /usr/local/bundle/gems/carrierwave-1.2.3/lib/carrierwave/uploader/configuration.rb:161:in `configure'

simahawk commented 4 years ago

fixed, this one is tested

sebastienbeau commented 4 years ago

LGTM, thanks for the fix