search

shopinvader / locomotive-shopinvader

LocomotiveCMS Plugin for Shopinvader
https://shopinvader.com
MIT License
12 stars 15 forks source link

[IMP] new languages #29

Closed sylvainc closed 5 years ago

rvalyi commented 5 years ago

Hello @sylvainc I have a doubt with theses locales with an underscore in the value. In Rails, it seems these locals have a - separator instead of , see here https://github.com/svenfuchs/rails-i18n#usage-on-rails-23 Are you sure, of theses codes with ? Where do they come from?

rvalyi commented 5 years ago

Or are these the Odoo locales may be?

sylvainc commented 5 years ago

Hello @rvalyi,

Yes indeed the left value with dash ("-") is the value in the LocomotiveCMS Rails application, and the right value with underscore ("_") value match the language code in the name of the Algolia index which comes from the internal Odoo languages code by Shopinvader configuration/convention, maybe that could be more documented.

Thanks for your attention.

Best regards

rvalyi commented 5 years ago

@sylvainc all right, that's fine then. Thanks.