search

shopinvader / locomotive-shopinvader

LocomotiveCMS Plugin for Shopinvader
https://shopinvader.com
MIT License
12 stars 15 forks source link

[FIX] Fix issue that restrict to 10 variants #53

Closed sebastienbeau closed 4 years ago

sebastienbeau commented 4 years ago

Elastic client limit by 10 the number of record return In case of searching a product we when all variants without limit This quick fix set to 10000 the limit. If we have more then 10000 variants we will have an issue. But having 10000 variants should never occured and maybe we should manage them in a different way. So let's see how to fix this issue the day we will have it. One possible thing is to add a optionnal config and keeping this default value.

sebastienbeau commented 4 years ago

@Laurent-Corron @lmignon I just ping you so you know that I have fixed this issue.

Laurent-Corron commented 4 years ago

small note: If we do need to request that many products it would be better to use the scroll method from elasticsearch as used here.