search

shopinvader / odoo-shopinvader-payment

GNU Affero General Public License v3.0
2 stars 10 forks source link

[FIX] do not set last_sale when not in customer session #45

Closed sbidoul closed 3 years ago

sbidoul commented 3 years ago

The SaleOrderPaymentTransactionEventListener is sometimes called when the transaction is confirmed by a webhook coming from the payment acquirer. We don't want to leak the store_cache to the payment acquirer, so we only set it if we are in a customer session.

To detect that we are in a customer session we check the sess-cart-id HTTP header.

This is part of the collection of ugly patches in this area.

sebastienbeau commented 3 years ago

/ocabot merge minor

shopinvader-git-bot commented 3 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

shopinvader-git-bot commented 3 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 13.0-ocabot-merge-pr-45-by-sebastienbeau-bump-minor, awaiting test results.

shopinvader-git-bot commented 3 years ago

Congratulations, your PR was merged at 44398a65ee3509b64bfbc8f0bba3d83b2033d5d6. Thanks a lot for contributing to shopinvader. ❤️