Closed simahawk closed 2 years ago
@simahawk Have you had a chance to test this in combination with #45 ? (we have #45 in production, no issues on our side)
@simahawk Have you had a chance to test this in combination with #45 ? (we have #45 in production, no issues on our side)
nope, I can give it a try
Merging #53 (de18d2a) into 13.0 (bb7135c) will decrease coverage by
19.89%
. The diff coverage is79.31%
.
@@ Coverage Diff @@
## 13.0 #53 +/- ##
===========================================
- Coverage 94.94% 75.04% -19.90%
===========================================
Files 14 48 +34
Lines 178 557 +379
Branches 0 39 +39
===========================================
+ Hits 169 418 +249
- Misses 9 120 +111
- Partials 0 19 +19
Impacted Files | Coverage Δ | |
---|---|---|
invader_payment_manual/services/payment_manual.py | 100.00% <ø> (ø) |
|
invader_payment_sips/services/payment_sips.py | 26.72% <28.57%> (ø) |
|
invader_payment_paypal/services/payment_paypal.py | 66.35% <66.35%> (ø) |
|
shopinvader_payment_paypal/controllers/main.py | 85.71% <85.71%> (ø) |
|
...nvader_payment/services/invader_payment_service.py | 78.57% <100.00%> (-13.74%) |
:arrow_down: |
invader_payment_paypal/__init__.py | 100.00% <100.00%> (ø) |
|
invader_payment_paypal/models/__init__.py | 100.00% <100.00%> (ø) |
|
invader_payment_paypal/models/payment_acquirer.py | 100.00% <100.00%> (ø) |
|
invader_payment_paypal/services/__init__.py | 100.00% <100.00%> (ø) |
|
.../components/payment_transaction_event_listerner.py | 86.36% <100.00%> (-5.31%) |
:arrow_down: |
... and 47 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6c54d1d...de18d2a. Read the comment docs.
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge minor
What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-53-by-sebastienbeau-bump-minor, awaiting test results.
@sebastienbeau The merge process could not start, because command `git merge --no-ff -m Merge PR #53 into 13.0
Signed-off-by sebastienbeau tmp-pr-53` failed with output:
Auto-merging shopinvader_payment/components/payment_transaction_event_listerner.py
CONFLICT (content): Merge conflict in shopinvader_payment/components/payment_transaction_event_listerner.py
Automatic merge failed; fix conflicts and then commit the result.
@sebastienbeau The merge process could not be finalized, because command `git merge --no-ff -m Merge PR #53 into 13.0
Signed-off-by sebastienbeau tmp-pr-53` failed with output:
Auto-merging shopinvader_payment/components/payment_transaction_event_listerner.py
CONFLICT (content): Merge conflict in shopinvader_payment/components/payment_transaction_event_listerner.py
Automatic merge failed; fix conflicts and then commit the result.
@mmequignon pls rebase
@mmequignon pls rebase
done
/ocabot merge minor
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 13.0-ocabot-merge-pr-53-by-simahawk-bump-minor, awaiting test results.
Congratulations, your PR was merged at 930f82882801d3216ac064a8554ec6443f590388. Thanks a lot for contributing to shopinvader. ❤️
Make sure that when the cart service is initialized we have the whole partner work context in good shape.
Depends on https://github.com/shopinvader/odoo-shopinvader/pull/957
Replaces #41