search

shopinvader / odoo-shopinvader-payment

GNU Affero General Public License v3.0
2 stars 10 forks source link

[14.0][MIG] shopinvader_invoice_payment #57

Closed acsonefho closed 1 year ago

acsonefho commented 3 years ago

Include also https://github.com/shopinvader/odoo-shopinvader-payment/pull/83 to check if it fix the merge Depends on

codecov-commenter commented 3 years ago

Codecov Report

Patch coverage: 89.38% and project coverage change: +0.73 :tada:

Comparison is base (b06ed53) 85.17% compared to head (fb895fd) 85.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 14.0 #57 +/- ## ========================================== + Coverage 85.17% 85.91% +0.73% ========================================== Files 65 79 +14 Lines 958 1214 +256 Branches 101 123 +22 ========================================== + Hits 816 1043 +227 - Misses 107 131 +24 - Partials 35 40 +5 ``` | [Impacted Files](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader) | Coverage Δ | | |---|---|---| | [.../components/payment\_transaction\_event\_listerner.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L2NvbXBvbmVudHMvcGF5bWVudF90cmFuc2FjdGlvbl9ldmVudF9saXN0ZXJuZXIucHk=) | `61.53% <61.53%> (ø)` | | | [shopinvader\_invoice\_payment/models/account\_move.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L21vZGVscy9hY2NvdW50X21vdmUucHk=) | `65.00% <65.00%> (ø)` | | | [shopinvader\_invoice\_payment/services/invoice.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L3NlcnZpY2VzL2ludm9pY2UucHk=) | `94.11% <94.11%> (ø)` | | | [shopinvader\_invoice\_payment/\_\_init\_\_.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [shopinvader\_invoice\_payment/components/\_\_init\_\_.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L2NvbXBvbmVudHMvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [shopinvader\_invoice\_payment/models/\_\_init\_\_.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L21vZGVscy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [...ader\_invoice\_payment/models/payment\_transaction.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L21vZGVscy9wYXltZW50X3RyYW5zYWN0aW9uLnB5) | `100.00% <100.00%> (ø)` | | | [...ader\_invoice\_payment/models/shopinvader\_payment.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L21vZGVscy9zaG9waW52YWRlcl9wYXltZW50LnB5) | `100.00% <100.00%> (ø)` | | | [shopinvader\_invoice\_payment/services/\_\_init\_\_.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L3NlcnZpY2VzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [...nvoice\_payment/services/invader\_payment\_service.py](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfaW52b2ljZV9wYXltZW50L3NlcnZpY2VzL2ludmFkZXJfcGF5bWVudF9zZXJ2aWNlLnB5) | `100.00% <100.00%> (ø)` | | | ... and [2 more](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader) | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/57/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rousseldenis commented 2 years ago

@PierrickBrun @Cedric-Pigeon This one is ready

acsonefho commented 1 year ago

@shopinvader/shopinvader-maintainers Review needed please :)

acsonefho commented 1 year ago

Code LGTM, small remark about commented code in tests

@PierrickBrun Thank you for your review. All the commented code is already cleaned. I think you were on old commit. Can you update your review please? And if you have super-power, can you merge? It's quite important to merge it quickly.

PierrickBrun commented 1 year ago

/ocabot merge patch

shopinvader-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-57-by-PierrickBrun-bump-patch, awaiting test results.

shopinvader-git-bot commented 1 year ago

@PierrickBrun your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-57-by-PierrickBrun-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

shopinvader-git-bot commented 1 year ago

@PierrickBrun your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-57-by-PierrickBrun-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

acsonefho commented 1 year ago

@PierrickBrun can you retry please? Should be ok after rebase and fix pre-commit :) Thanks!

acsonefho commented 1 year ago

@PierrickBrun can you retry please?

PierrickBrun commented 1 year ago

/ocabot merge patch

shopinvader-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-57-by-PierrickBrun-bump-patch, awaiting test results.

shopinvader-git-bot commented 1 year ago

@PierrickBrun your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-57-by-PierrickBrun-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

shopinvader-git-bot commented 1 year ago

@PierrickBrun your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-57-by-PierrickBrun-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

acsonefho commented 1 year ago

@PierrickBrun I include an update of pre-commit (the cause of failure during merge). Can you retry the merge please?

PierrickBrun commented 1 year ago

/ocabot merge patch

shopinvader-git-bot commented 1 year ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-57-by-PierrickBrun-bump-patch, awaiting test results.

shopinvader-git-bot commented 1 year ago

Congratulations, your PR was merged at cf3b22ca0bfe16654d8bdc1f1047a578f015657f. Thanks a lot for contributing to shopinvader. ❤️