shopinvader / odoo-shopinvader-payment

GNU Affero General Public License v3.0
2 stars 10 forks source link

[MIG] shopinvader_payment_sips, invader_payment_sips: black, isort, prettier #63

Open sebastienbeau opened 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.40% :tada:

Comparison is base (391b742) 76.18% compared to head (5aaa5a2) 76.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 14.0 #63 +/- ## ========================================== + Coverage 76.18% 76.58% +0.40% ========================================== Files 115 123 +8 Lines 1793 1952 +159 Branches 217 233 +16 ========================================== + Hits 1366 1495 +129 - Misses 369 390 +21 - Partials 58 67 +9 ``` | [Files Changed](https://app.codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader) | Coverage Δ | | |---|---|---| | [invader\_payment\_sips/services/payment\_sips.py](https://app.codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-aW52YWRlcl9wYXltZW50X3NpcHMvc2VydmljZXMvcGF5bWVudF9zaXBzLnB5) | `74.57% <ø> (ø)` | | | [shopinvader\_payment/tests/common.py](https://app.codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfcGF5bWVudC90ZXN0cy9jb21tb24ucHk=) | `100.00% <100.00%> (ø)` | | | [...nvader\_payment\_manual/tests/test\_payment\_manual.py](https://app.codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfcGF5bWVudF9tYW51YWwvdGVzdHMvdGVzdF9wYXltZW50X21hbnVhbC5weQ==) | `100.00% <100.00%> (ø)` | | | [shopinvader\_payment\_sips/tests/\_\_init\_\_.py](https://app.codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfcGF5bWVudF9zaXBzL3Rlc3RzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [...hopinvader\_payment\_sips/tests/test\_payment\_sips.py](https://app.codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-c2hvcGludmFkZXJfcGF5bWVudF9zaXBzL3Rlc3RzL3Rlc3RfcGF5bWVudF9zaXBzLnB5) | `100.00% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/63/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sebastienbeau commented 1 year ago

@sbidoul I have a black / isort issue here

Black is convert the one line in two line with parentheses isort convert the line with parentheses to one line


-from odoo.addons.invader_payment_sips.services.payment_sips import (
-    _sips_make_seal,
-)
-from odoo.addons.shopinvader_payment.tests.common import (
-    CommonConnectedPaymentCase,
-)
+from odoo.addons.invader_payment_sips.services.payment_sips import _sips_make_seal
+from odoo.addons.shopinvader_payment.tests.common import CommonConnectedPaymentCase