codecov-commenter
commented
2 years ago Codecov Report
Merging #68 (ddee229) into 14.0 (07ad0b6) will increase coverage by
3.16%. The diff coverage is69.56%.
@@ Coverage Diff @@
## 14.0 #68 +/- ##
==========================================
+ Coverage 88.17% 91.33% +3.16%
==========================================
Files 38 50 +12
Lines 389 531 +142
Branches 40 53 +13
==========================================
+ Hits 343 485 +142
Misses 35 35
Partials 11 11 | Impacted Files | Coverage Δ | |
|---|---|---|
| test_invader_payment/services/__init__.py | 100.00% <ø> (ø) |
|
| test_invader_payment/tests/__init__.py | 100.00% <ø> (ø) |
|
| invader_payment_stripe/services/payment_stripe.py | 75.00% <64.10%> (+16.02%) |
:arrow_up: |
| test_invader_payment/models/res_partner.py | 100.00% <100.00%> (ø) |
|
| ...vader_payment/tests/test_invader_payment_stripe.py | 100.00% <100.00%> (ø) |
|
| ...nvader_payment/services/invader_payment_service.py | 84.61% <0.00%> (ø) |
|
| test_invader_payment/components/__init__.py | 100.00% <0.00%> (ø) |
|
| .../components/payment_transaction_event_listerner.py | 100.00% <0.00%> (ø) |
|
| test_invader_payment/services/payment_stripe.py | 100.00% <0.00%> (ø) |
|
| test_invader_payment/tests/common.py | 100.00% <0.00%> (ø) |
|
| ... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 07ad0b6...ddee229. Read the comment docs.
Depends on: #67
Synchronous flow has some drawbacks so it could be nice to support both sync and async flows: https://stripe.com/docs/payments/accept-a-payment-synchronously
Also Payment Element can be useful and only works in Asynchronous mode: https://stripe.com/docs/payments/payment-element