Closed acsonefho closed 1 year ago
@acsonefho @Cedric-Pigeon It could be great to realign PR's in order to make them merged.
@shopinvader/shopinvader-maintainers Can I have review/merge please? Already in production so functionally working
There is a lot of duplicated code for invoices and sale orders that could be refactored.
I think using the abstract "payable" object would be a good solution to that and be more aligned with the rest of the repo.
You're totally right! It was a discussion that I had today. I'll do it soon
Base: 85.17% // Head: 83.44% // Decreases project coverage by -1.74%
:warning:
Coverage data is based on head (
88734f6
) compared to base (b06ed53
). Patch coverage: 77.07% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@shopinvader/shopinvader-maintainers Some review here please? Huge one...
Already in production and working properly.
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-77-by-Cedric-Pigeon-bump-patch, awaiting test results.
Congratulations, your PR was merged at adc9c483c976595ded60e1be23f1970a1167568e. Thanks a lot for contributing to shopinvader. ❤️
Add some information related to Klarna on the request to do the payment.
Depends on https://github.com/shopinvader/odoo-shopinvader-payment/pull/57
But also some refactor:
I did the refactor into a dedicated commit. I also did this into this PR because it's quite hard to do some test with multi-pr (with a lot of abstraction) and then this PR will depends on many other PR.