search

shopinvader / odoo-shopinvader-payment

GNU Affero General Public License v3.0
3 stars 11 forks source link

[10.0] backport new payment api #9

Closed lmignon closed 5 years ago

lmignon commented 5 years ago

supersedes #8

lmignon commented 5 years ago

@sebastienbeau This PR is almost finished. Tests into test_shopinvader_payment fails due to a bug into onchange_helper This bug is fixed by https://github.com/OCA/server-tools/pull/1510. I'm working on it to fix the tests

lmignon commented 5 years ago

@sebastienbeau This PR is almost finished. Tests into test_shopinvader_payment fails due to a bug into onchange_helper This bug is fixed by https://github.com/OCA/server-tools/pull/1510. I'm working on it to fix the tests

codecov-io commented 5 years ago

Codecov Report

Merging #9 into 10.0 will decrease coverage by 9.56%. The diff coverage is 77.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0       #9      +/-   ##
==========================================
- Coverage   87.58%   78.02%   -9.57%     
==========================================
  Files          14       33      +19     
  Lines         290      628     +338     
==========================================
+ Hits          254      490     +236     
- Misses         36      138     +102
Impacted Files Coverage Δ
...pinvader_payment_manual/services/payment_manual.py 100% <100%> (ø)
...nvader_payment/services/invader_payment_service.py 100% <100%> (ø)
test_invader_payment/services/payment_stripe.py 100% <100%> (ø)
test_invader_payment/services/payment_manual.py 100% <100%> (ø)
invader_payment/models/account_payment_mode.py 100% <100%> (ø)
...pinvader_payment_stripe/services/payment_stripe.py 100% <100%> (ø)
shopinvader_quotation_payment/services/cart.py 100% <100%> (ø) :arrow_up:
shopinvader_payment/services/cart.py 100% <100%> (ø) :arrow_up:
shopinvader_payment_sips/services/payment_sips.py 100% <100%> (ø)
...hopinvader_quotation_payment/services/quotation.py 100% <100%> (+5.26%) :arrow_up:
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98ca392...5b85859. Read the comment docs.

lmignon commented 5 years ago

/ocabot merge major

shopinvader-git-bot commented 5 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 10.0-ocabot-merge-pr-9-by-lmignon-bump-major, awaiting test results.

shopinvader-git-bot commented 5 years ago

@lmignon The merge process could not be finalized, because command git rebase 10.0 failed with output:

First, rewinding head to replay your work on top of it...
Applying: [12.0][MIG] shopinvader_payment, shopinvader_payment_stripe
Using index info to reconstruct a base tree...
M   shopinvader_payment/README.rst
M   shopinvader_payment/static/description/index.html
M   shopinvader_payment_stripe/README.rst
M   shopinvader_payment_stripe/static/description/index.html
Falling back to patching base and 3-way merge...
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_visa.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_risk_highest.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_risk_elevated.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_france.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_expired_card.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_brazil.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_3d_required_success_webhook.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_3d_required_success.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_3d_required_failed_webhook.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_3d_required_failed.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_3d_optional_success_webhook.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_3d_optional_success.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_3d_optional_failed_webhook.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_3d_optional_failed.yaml
Removing shopinvader_payment_stripe/tests/fixtures/cassettes/test_create_transaction_3d_not_supported.yaml
Auto-merging shopinvader_payment_stripe/static/description/index.html
CONFLICT (content): Merge conflict in shopinvader_payment_stripe/static/description/index.html
Removing shopinvader_payment_stripe/services/payment_service.py
Removing shopinvader_payment_stripe/demo/shopinvader_payment_demo.xml
Auto-merging shopinvader_payment_stripe/README.rst
CONFLICT (content): Merge conflict in shopinvader_payment_stripe/README.rst
Auto-merging shopinvader_payment/static/description/index.html
CONFLICT (content): Merge conflict in shopinvader_payment/static/description/index.html
Removing shopinvader_payment/services/abstract_payment.py
Removing shopinvader_payment/controllers/main.py
Removing shopinvader_payment/controllers/__init__.py
Auto-merging shopinvader_payment/README.rst
CONFLICT (content): Merge conflict in shopinvader_payment/README.rst
Patch failed at 0001 [12.0][MIG] shopinvader_payment, shopinvader_payment_stripe
Use 'git am --show-current-patch' to see the failed patch

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
sebastienbeau commented 5 years ago

\O/ !!!! allez petit bot vas y!

lmignon commented 5 years ago

/ocabot merge major

shopinvader-git-bot commented 5 years ago

On my way to merge this fine PR! Prepared branch 10.0-ocabot-merge-pr-9-by-lmignon-bump-major, awaiting test results.

shopinvader-git-bot commented 5 years ago

@lmignon The merge process could not be finalized, because command twine check failed with output:

usage: twine check [-h] dist [dist ...]
twine check: error: the following arguments are required: dist
lmignon commented 5 years ago

/ocabot merge major

shopinvader-git-bot commented 5 years ago

This PR looks fantastic, let's merge it! Prepared branch 10.0-ocabot-merge-pr-9-by-lmignon-bump-major, awaiting test results.

shopinvader-git-bot commented 5 years ago

@lmignon The merge process could not be finalized, because command twine check failed with output:

usage: twine check [-h] dist [dist ...]
twine check: error: the following arguments are required: dist
lmignon commented 5 years ago

/ocabot merge major

shopinvader-git-bot commented 5 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 10.0-ocabot-merge-pr-9-by-lmignon-bump-major, awaiting test results.

shopinvader-git-bot commented 5 years ago

@lmignon The merge process could not be finalized, because command twine check failed with output:

usage: twine check [-h] dist [dist ...]
twine check: error: the following arguments are required: dist
lmignon commented 5 years ago

/ocabot merge major

shopinvader-git-bot commented 5 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 10.0-ocabot-merge-pr-9-by-lmignon-bump-major, awaiting test results.

shopinvader-git-bot commented 5 years ago

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-9-by-lmignon-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

lmignon commented 5 years ago

/ocabot merge major

shopinvader-git-bot commented 5 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 10.0-ocabot-merge-pr-9-by-lmignon-bump-major, awaiting test results.

shopinvader-git-bot commented 5 years ago

@lmignon The merge process could not be finalized, because command twine check failed with output:

usage: twine check [-h] dist [dist ...]
twine check: error: the following arguments are required: dist
rousseldenis commented 5 years ago

@lmignon All green !!! :green_apple:

lmignon commented 5 years ago

/ocabot merge major

shopinvader-git-bot commented 5 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 10.0-ocabot-merge-pr-9-by-lmignon-bump-major, awaiting test results.

shopinvader-git-bot commented 5 years ago

Congratulations, your PR was merged at 9a70328fb46abe671c6c0b22720cb937b0fdfc0f. Thanks a lot for contributing to shopinvader. ❤️