search

shopinvader / odoo-shopinvader-payment

GNU Affero General Public License v3.0
2 stars 10 forks source link

[14.0][FIX] invader_payment_adyen: Missing PSP #92

Closed acsonefho closed 9 months ago

acsonefho commented 10 months ago

In some case, the payment checkout doesn't send enough information (paymentData empty and no pspReference). As the psp is required (link between Odoo and Adyen), we have to fill it during this step. This value is also into response.psp.

codecov-commenter commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (391b742) 76.18% compared to head (2b681eb) 76.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 14.0 #92 +/- ## ======================================= Coverage 76.18% 76.18% ======================================= Files 115 115 Lines 1793 1793 Branches 217 217 ======================================= Hits 1366 1366 Misses 369 369 Partials 58 58 ``` | [Files](https://app.codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader) | Coverage Δ | | |---|---|---| | [...nvader\_payment\_adyen/models/payment\_transaction.py](https://app.codecov.io/gh/shopinvader/odoo-shopinvader-payment/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shopinvader#diff-aW52YWRlcl9wYXltZW50X2FkeWVuL21vZGVscy9wYXltZW50X3RyYW5zYWN0aW9uLnB5) | `59.37% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

acsonefho commented 10 months ago

@shopinvader/shopinvader-maintainers @rousseldenis Can you review/merge this little fix please :pray:

acsonefho commented 10 months ago

@shopinvader/shopinvader-maintainers Again a quick one to review and merge :pray: In production for few weeks.

Cedric-Pigeon commented 10 months ago

/ocabot merge patch

shopinvader-git-bot commented 10 months ago

@Cedric-Pigeon The merge process could not start, because of exception [Errno 13] Permission denied: '/app/run/.cache/oca-mqt'.

acsonefho commented 9 months ago

@shopinvader/shopinvader-maintainers What's the blocking point? Easy one

sbidoul commented 9 months ago

/ocabot merge patch

shopinvader-git-bot commented 9 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-92-by-sbidoul-bump-patch, awaiting test results.

shopinvader-git-bot commented 9 months ago

@sbidoul your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-92-by-sbidoul-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

sbidoul commented 9 months ago

/ocabot merge patch

shopinvader-git-bot commented 9 months ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-92-by-sbidoul-bump-patch, awaiting test results.

shopinvader-git-bot commented 9 months ago

It looks like something changed on 14.0 in the meantime. Let me try again (no action is required from you). Prepared branch 14.0-ocabot-merge-pr-92-by-sbidoul-bump-patch, awaiting test results.

shopinvader-git-bot commented 9 months ago

Congratulations, your PR was merged at 3d5a8478af58417baa1632efc84789e25d5adfca. Thanks a lot for contributing to shopinvader. ❤️