Closed marielejeune closed 10 months ago
This module will maybe need some schemas adaptations when https://github.com/shopinvader/odoo-shopinvader/pull/1421 will be finished but it's ready for first reviews.
@marielejeune ciao, any plan to finish this? BTW I opened a PR against your branch to fix perms, see https://github.com/acsone/odoo-shopinvader/pull/8 Could you have a look at it?
Hi @simahawk , this is finished and waiting for reviews :-) Feel free also to have a look at the dependent PR in OCA/sale-workflow
CHANGES (following the logic in https://github.com/shopinvader/odoo-shopinvader/pull/1495)
deprecated=True
)cart_uuid
is now of type UUID
, not str
anymore_sync_cart
method: don't apply rewards on a non existing cart@marielejeune ciao, any plan to finish this? BTW I opened a PR against your branch to fix perms, see acsone#8 Could you have a look at it?
I've cherry-picked your commit
@marielejeune All your dev dependencies are now merged... can you cleanup the test-requirements plz?
I've also added the current
alias on the new cart routes, and sorted them.
/ocabot merge path
Hi @lmignon. Your command failed:
Invalid options for command merge: path
.
Ocabot commands
ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}
More information
/ocabot merge patch
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1430-by-lmignon-bump-patch, awaiting test results.
It looks like something changed on 16.0
in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1430-by-lmignon-bump-patch, awaiting test results.
It looks like something changed on 16.0
in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1430-by-lmignon-bump-patch, awaiting test results.
Congratulations, your PR was merged at b64c0ca35a8a555eeb56f492ee9ce511b6783d61. Thanks a lot for contributing to shopinvader. ❤️
FastAPI services for applying coupons to cart.
Depends on
TODO
/apply_coupon
service must be oncart
router, notloyalty
router/apply_reward
to apply a claimable reward (automatic program, without code)CartResponse
must return all claimable rewards, so that before validating the cart, if some rewards are still claimable, they can be applied (by calling the/apply_reward
service, chosing the right reward / free product).shopinvader_cart_user_group
must have theshopinvader_loyalty_user_group
as it uses all loyalties concepts.reward_amount
andreward_amount_tax_included
.