shopinvader / odoo-shopinvader

Odoo Modules. Sorry Magento, Shopinvader is coming
GNU Affero General Public License v3.0
121 stars 105 forks source link

[16.0][ADD] shopinvader_api_sale_loyalty: FastAPI services to apply coupons #1430

Closed marielejeune closed 10 months ago

marielejeune commented 1 year ago

FastAPI services for applying coupons to cart.

Depends on

TODO

marielejeune commented 1 year ago

This module will maybe need some schemas adaptations when https://github.com/shopinvader/odoo-shopinvader/pull/1421 will be finished but it's ready for first reviews.

simahawk commented 10 months ago

@marielejeune ciao, any plan to finish this? BTW I opened a PR against your branch to fix perms, see https://github.com/acsone/odoo-shopinvader/pull/8 Could you have a look at it?

marielejeune commented 10 months ago

Hi @simahawk , this is finished and waiting for reviews :-) Feel free also to have a look at the dependent PR in OCA/sale-workflow

marielejeune commented 10 months ago

CHANGES (following the logic in https://github.com/shopinvader/odoo-shopinvader/pull/1495)

marielejeune commented 10 months ago

@marielejeune ciao, any plan to finish this? BTW I opened a PR against your branch to fix perms, see acsone#8 Could you have a look at it?

I've cherry-picked your commit

lmignon commented 10 months ago

@marielejeune All your dev dependencies are now merged... can you cleanup the test-requirements plz?

marielejeune commented 10 months ago

I've also added the current alias on the new cart routes, and sorted them.

lmignon commented 10 months ago

/ocabot merge path

shopinvader-git-bot commented 10 months ago

Hi @lmignon. Your command failed:

Invalid options for command merge: path.

Ocabot commands

More information

lmignon commented 10 months ago

/ocabot merge patch

shopinvader-git-bot commented 10 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1430-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot commented 10 months ago

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-1430-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot commented 10 months ago

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-1430-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot commented 10 months ago

Congratulations, your PR was merged at b64c0ca35a8a555eeb56f492ee9ce511b6783d61. Thanks a lot for contributing to shopinvader. ❤️