search

shopinvader / odoo-shopinvader

Odoo Modules. Sorry Magento, Shopinvader is coming
GNU Affero General Public License v3.0
121 stars 105 forks source link

[16.0][FIX] shopinvader_api_cart: Returns 204 if no content #1488

Closed lmignon closed 11 months ago

lmignon commented 11 months ago

This is required to avoid to try to convert a null body value into json on client side. If we return nothing, we must explicitly set the right response code

This change is required for and works with https://github.com/shopinvader/shopinvader-js-cart/pull/11

It will avoid to get the cart set into the 'sync error' status if the call the the 'sync' endpoint return an empty response.

lmignon commented 11 months ago

/ocabot merge patch

shopinvader-git-bot commented 11 months ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-1488-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot commented 11 months ago

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-1488-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot commented 11 months ago

Congratulations, your PR was merged at f091096d503103a41d9fbd5ef0dab7d6f6de306f. Thanks a lot for contributing to shopinvader. ❤️