search

shopinvader / odoo-shopinvader

Odoo Modules. Sorry Magento, Shopinvader is coming
GNU Affero General Public License v3.0
121 stars 105 forks source link

[16.0][ADD] shopinvader_search_engine_product_multi_price #1498

Closed qgroulard closed 6 months ago

qgroulard commented 10 months ago

See https://github.com/shopinvader/odoo-shopinvader/pull/1441 and https://github.com/shopinvader/odoo-shopinvader/pull/1467 for PRs on related matter.

  1. Remove price from the schema in shopinvader_product as there are a lot of different ways to expose product prices and they should be handled in dedicated modules. '_get_price()' method has already been extracted to OCA/product-attribute module 'product_get_price_helper'.

  2. Add a module to export prices for a list of pricelists set on the index or backend.

simahawk commented 9 months ago

@qgroulard the 1st commit can be dropped now, no?

qgroulard commented 9 months ago

@qgroulard the 1st commit can be dropped now, no?

In theory yes, the keys price and prices can coexist.

But I think price should be removed anyway as it is a broken first draft. Prices were still WIP when schemas have been merged, keeping it on the main branch seems wrong to me.

simahawk commented 9 months ago

@qgroulard the 1st commit can be dropped now, no?

In theory yes, the keys price and prices can coexist.

But I think price should be removed anyway as it is a broken first draft. Prices were still WIP when schemas have been merged, keeping it on the main branch seems wrong to me.

I meant that you already removed it when creating the helper module, no?

simahawk commented 9 months ago

@qgroulard the 1st commit can be dropped now, no?

In theory yes, the keys price and prices can coexist. But I think price should be removed anyway as it is a broken first draft. Prices were still WIP when schemas have been merged, keeping it on the main branch seems wrong to me.

I meant that you already removed it when creating the helper module, no?

It seems not, in fact :sweat_smile:

simahawk commented 9 months ago

@qgroulard can we fast track https://github.com/shopinvader/odoo-shopinvader/pull/1507 while fixing this one?

simahawk commented 7 months ago

@qgroulard ping :)

lmignon commented 6 months ago

/ocabot merge nobump

shopinvader-git-bot commented 6 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-1498-by-lmignon-bump-nobump, awaiting test results.

shopinvader-git-bot commented 6 months ago

Congratulations, your PR was merged at d544edf7ea470eff3bb38623e45f8ab5c717345d. Thanks a lot for contributing to shopinvader. ❤️