search

shopinvader / odoo-shopinvader

Odoo Modules. Sorry Magento, Shopinvader is coming
GNU Affero General Public License v3.0
121 stars 105 forks source link

[16.0] [IMP] shopinvader_api_cart: don't use `self.env.norecompute` #1500

Closed ivantodorovich closed 9 months ago

ivantodorovich commented 9 months ago

This context manager has been deprecated since many versions now, and it's not doing absolutely anything.

It was originally used to prevent computed fields to be recomputed when their dependencies are updated, but that's not the case anymore since the apparition of flush, where the recomputation is delayed.

See: https://github.com/odoo/odoo/blob/be4c1502/odoo/api.py#L823-L826 Also: https://github.com/odoo/odoo/commit/9920f20e

simahawk commented 9 months ago

/ocabot merge patch

shopinvader-git-bot commented 9 months ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-1500-by-simahawk-bump-patch, awaiting test results.

shopinvader-git-bot commented 9 months ago

Congratulations, your PR was merged at f833d61106af30554d726953b35bc29676fb68cc. Thanks a lot for contributing to shopinvader. ❤️