shopinvader / odoo-shopinvader

Odoo Modules. Sorry Magento, Shopinvader is coming
GNU Affero General Public License v3.0
121 stars 105 forks source link

[16.0] [IMP] shopinvader_api_cart: Allow to modify the commitment date #1501

Closed ivantodorovich closed 9 months ago

ivantodorovich commented 9 months ago

Allow to modify the cart's commitment date

simahawk commented 9 months ago

@lmignon good for you?

ivantodorovich commented 9 months ago

Thanks for you review and your comments, @lmignon !

Sorry for not replying sooner, I really wanted to check with our functional colleagues before answering here.

You are certainly right. In our project, we will rely on automated rules and constraints.. so we will let the customer choose the delivery date (commitment_date field). However, without them, it makes no sense to expose this field.. so we shouldn't do it in shopinvader core

I'll close it. Many thanks!

lmignon commented 9 months ago

@ivantodorovich You're welcome ;-)