search

shopinvader / odoo-shopinvader

Odoo Modules. Sorry Magento, Shopinvader is coming
GNU Affero General Public License v3.0
121 stars 105 forks source link

shopinvader_search_engine: ease override of depends for category compute #1527

Open cyrilmanuel opened 7 months ago

cyrilmanuel commented 7 months ago

ease override of depends for category compute to be override by other category fields.

simahawk commented 7 months ago

Not a "fix" :wink: Also, can you please remove the odoo version from the commit? Should be something like shopinvader_search_engine: ease override of depends for category compute

shopinvader-git-bot commented 7 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

cyrilmanuel commented 7 months ago

hii @lmignon can you merge this PR ?

cyrilmanuel commented 5 months ago

hi @lmignon i think we have 50 50. can we merge it to go ahead please ?

lmignon commented 5 months ago

hi @lmignon i think we have 50 50. can we merge it to go ahead please ?

We'll keep the native approach and not not merge this one. I'm don't know how Odoo will work if both approach are used at same time and I would avoid to constrain everyone to use this specific one and have to know it must override a specific method.