search

shopinvader / odoo-shopinvader

Odoo Modules. Sorry Magento, Shopinvader is coming
GNU Affero General Public License v3.0
119 stars 103 forks source link

[16.0] shopinvader_api_cart: add /new endpoint #1533

Closed simahawk closed 2 months ago

simahawk commented 5 months ago

Allows to force creation of carts the same customer.

lmignon commented 4 months ago

@qgroulard What about the merge mechanism with anonymous users?

shopinvader-git-bot commented 4 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

qgroulard commented 4 months ago

@qgroulard What about the merge mechanism with anonymous users?

It will merge one of the anonymous carts with one of the carts of the user.

@simahawk More globally, why do you need several carts and how do you expect them to work ? Some part of shopinvader are not meant to work with multiple carts (at least I know this method (and the anonymous cart)).

simahawk commented 3 months ago

@qgroulard What about the merge mechanism with anonymous users?

It will merge one of the anonymous carts with one of the carts of the user.

Yes. Of course, this is not meant to be used by anon users.

@simahawk More globally, why do you need several carts and how do you expect them to work ? Some part of shopinvader are not meant to work with multiple carts (at least I know this method (and the anonymous cart)).

When you create one you get the UUID so you don´t need to find it later to update it.

/ocabot merge minor

simahawk commented 2 months ago

/ocabot merge minor

shopinvader-git-bot commented 2 months ago

@simahawk The merge process could not start, because command git fetch --quiet --force --prune https://github.com/shopinvader/odoo-shopinvader 'refs/heads/*:refs/heads/*' failed with output:

fatal: detected dubious ownership in repository at '/app/run/.cache/oca-mqt/github.com/shopinvader/odoo-shopinvader'
To add an exception for this directory, call:

    git config --global --add safe.directory /app/run/.cache/oca-mqt/github.com/shopinvader/odoo-shopinvader
shopinvader-git-bot commented 2 months ago

@simahawk The merge process could not start, because command git fetch --quiet --force --prune https://github.com/shopinvader/odoo-shopinvader 'refs/heads/*:refs/heads/*' failed with output:

fatal: detected dubious ownership in repository at '/app/run/.cache/oca-mqt/github.com/shopinvader/odoo-shopinvader'
To add an exception for this directory, call:

    git config --global --add safe.directory /app/run/.cache/oca-mqt/github.com/shopinvader/odoo-shopinvader
simahawk commented 2 months ago

/ocabot merge minor

shopinvader-git-bot commented 2 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-1533-by-simahawk-bump-minor, awaiting test results.

shopinvader-git-bot commented 2 months ago

Congratulations, your PR was merged at 88eccb3438133407b1f339b6bb5abcc2c7d52e82. Thanks a lot for contributing to shopinvader. ❤️