[16.0][FIX] shopinvader_api_sale_loyalty: Don't extend existing router

[lmignon]

To preserve that only routers for installed addons are used, you can't import router from another addon to add new routes. You must always create your own router. By using the same tags in our router declaration we ensure that the new routes are displayed next to the existing ones declared for the same tags

[lmignon]

/ocabot merge minor

[shopinvader-git-bot]

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-1558-by-lmignon-bump-minor, awaiting test results.

[shopinvader-git-bot]

@lmignon The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name shopinvader --repo-name odoo-shopinvader --branch 16.0 --addons-dir /tmp/tmp_iuj5yph --commit failed with output:

/tmp/tmp_iuj5yph/shopinvader_api_sale_loyalty/README.rst:52: (ERROR/3) Unexpected indentation.
Traceback (most recent call last):
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2793, in text
    block = self.state_machine.get_text_block(flush_left=True)
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 403, in get_text_block
    block = self.input_lines.get_text_block(self.line_offset,
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 1352, in get_text_block
    raise UnexpectedIndentationError(self[start:end], source,
docutils.statemachine.UnexpectedIndentationError: (StringList(['`sale_loyalty_cart_router`. The `sale_loyalty_cart_router` is declared', 'with the same tags as the one defined in the `shopinvader_api_cart`', 'addon. As this one, no prefix is added to the router, to allow to mount', 'it as a nested app. See the README of `shopinvader_api_cart` for'], items=[('/tmp/tmp_iuj5yph/shopinvader_api_sale_loyalty/README.rst', 47), ('/tmp/tmp_iuj5yph/shopinvader_api_sale_loyalty/README.rst', 48), ('/tmp/tmp_iuj5yph/shopinvader_api_sale_loyalty/README.rst', 49), ('/tmp/tmp_iuj5yph/shopinvader_api_sale_loyalty/README.rst', 50)]), '/tmp/tmp_iuj5yph/shopinvader_api_sale_loyalty/README.rst', 52)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
    load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 537, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 388, in check_rst
    publish_file(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 422, in publish_file
    output, publisher = publish_programmatically(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 722, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 234, in publish
    self.document = self.reader.read(self.source, self.parser,
  File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 70, in read
    self.parse()
  File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 76, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 169, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 3024, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2785, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2796, in text
    msg = self.reporter.error('Unexpected indentation.',
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 231, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 197, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmp_iuj5yph/shopinvader_api_sale_loyalty/README.rst:52: (ERROR/3) Unexpected indentation.

[lmignon]

/ocabot merge minor

[shopinvader-git-bot]

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-1558-by-lmignon-bump-minor, awaiting test results.

[shopinvader-git-bot]

Congratulations, your PR was merged at d41784fd3e0037908926616a49590b7f93021c86. Thanks a lot for contributing to shopinvader. ❤️