search

shopinvader / odoo-shopinvader

Odoo Modules. Sorry Magento, Shopinvader is coming
GNU Affero General Public License v3.0
121 stars 104 forks source link

RFC Merge locomotive settings schema fields all in once #490

Closed simahawk closed 1 year ago

simahawk commented 5 years ago

Use case: add a new field to the schema https://github.com/shopinvader/odoo-shopinvader/pull/476 ATM you cannot simply export new data to locomotive because you need that field to be present in its metafields schema.

IMO we should have only one bucket for such settings (eg: odoo_settings or erp_settings) which contains all the settings we need (eg: available_countries, languages, currencies, etc) This way, no matter what we export, we don't have to do anything on the schema of the locomotive site (which is quite fragile in case of data deployment).

As long as we don't implement #489 I propose we add a flag the backend "Wrapped locomotive settings" to wrap the content of the export only if we already have an up top date locomotive instance.

@lmignon @sebastienbeau I'd like to hear your opinion :)

lmignon commented 5 years ago

@simahawk I like this idea. BUT we must document the changes and explain how an existing website can be migrated.

simahawk commented 5 years ago

@lmignon as you mentioned in #489 we are already reading existing settings and we can check what's available there. We could rely on it instead of adding a new flag. I totally agree: this must be documented properly.

lmignon commented 5 years ago

@simahawk Can you check that if we export unknow settings to locomotive these are ignored. I've the feeling that the schema into locomotive is only used to allow the edition of these settings from within the admin site.

simahawk commented 5 years ago

had a call w/ @sebastienbeau yesterday: we agreed on wrapping settings only if the settings key is found on the existing instance (even if using "reset"). To keep existing instances safe, we can still push a copy of old info to the old static metafields.

simahawk commented 5 years ago

@lmignon you were right: apparently you can send whatever you want, locomotive won't complain. In my opinion we should still wrap settings but seems is not fundamental ATM. CC @sebastienbeau

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.