shopinvader / odoo-shopinvader

Odoo Modules. Sorry Magento, Shopinvader is coming
GNU Affero General Public License v3.0
121 stars 104 forks source link

Secure params decorator => move on send to service #67

Closed sebastienbeau closed 6 years ago

sebastienbeau commented 7 years ago

After thinking twice, instead of using a decorator for securing the params the best will to implement that check in the send_to_service method https://github.com/akretion/odoo-shopinvader/blob/10-shopinvader-migration/shopinvader/controllers/main.py#L25

This will be more secure because we can forget a decorator, and also avoid issue when you want to inherit a function that have been already decorated.

I will do it here during the migration https://github.com/akretion/odoo-shopinvader/pull/64

sebastienbeau commented 6 years ago

DONE in base_rest