search

shopinvader / pattern-import-export

Module that allows to configure a pattern file for import/export
GNU Affero General Public License v3.0
11 stars 16 forks source link

[FIX] avoid crash when changing a relational field to simple field #108

Closed florian-dacosta closed 6 months ago

florian-dacosta commented 2 years ago

Example of crash before this fix : on res.partner, choose country_id as field1_id and code as field2_id then change field1_id for active name field is not updated yet at the time it goes through _get_last_relation_field so odoo expected a relational field even though it is not anymore and crashes.

Kev-Roche commented 2 years ago

code and functionnal review LGTM

hparfr commented 1 year ago

/ocabot merge minor

shopinvader-git-bot commented 1 year ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-108-by-hparfr-bump-minor, awaiting test results.

shopinvader-git-bot commented 1 year ago

@hparfr your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-108-by-hparfr-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

florian-dacosta commented 6 months ago

@hparfr I did rebase, maybe you could try again to merge it

hparfr commented 6 months ago

/ocabot merge minor

shopinvader-git-bot commented 6 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-108-by-hparfr-bump-minor, awaiting test results.

shopinvader-git-bot commented 6 months ago

Congratulations, your PR was merged at 2d199486b381bc717b66309699770a2c6a804b50. Thanks a lot for contributing to shopinvader. ❤️