search

shopinvader / pattern-import-export

Module that allows to configure a pattern file for import/export
GNU Affero General Public License v3.0
11 stars 16 forks source link

[14.0][FIX] pattern_import_export right for user to export #115

Closed Kev-Roche closed 1 year ago

Kev-Roche commented 1 year ago

Actually, exporting a pattern requires write access on pattern.config but only pattern manager can, not pattern user. This PR add write right on pattern.config for pattern user group. UPDATE : remove the write right and add sudo right on export creation

sebastienbeau commented 1 year ago

We should not add the access right for basic user, to discuss

Kev-Roche commented 1 year ago

@sebastienbeau, I remove the write right and add sudo() on pattern creation like you suggested

sebastienbeau commented 1 year ago

/ocabot merge patch

shopinvader-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-115-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

shopinvader-git-bot commented 1 year ago

Congratulations, your PR was merged at 5ca956801e13807a41da78c4cfbce80bb10697bf. Thanks a lot for contributing to shopinvader. ❤️