Refactor Code to Improve Code Quality by Removing Implementation and Design Smells - Githubissues

shopizer-ecommerce / shopizer

Shopizer java e-commerce software

http://www.shopizer.com

Apache License 2.0

3.52k stars 2.98k forks source link

Refactor Code to Improve Code Quality by Removing Implementation and Design Smells #1007

Open LuvPatel opened 5 months ago

LuvPatel commented 5 months ago

The Following Type Of Refactoring were applied to remove code smells and improve code quality :

Implementation Smell Refactoring :

1). Decompose Conditional

Path : sm-core/src/main/java/com/salesmanager/core/business/repositories/catalog/product
Class : ProductRepositoryImpl
Method : listByStore

2). Extract Method

Path : sm-shop/src/main/java/com/salesmanager/shop/store/controller/shoppingCart.facade
Class: ShoppingCartFacadeImpl
Method : getByCode

3). Rename Variable

Path : sm-core/src/main/java/com/salesmanager/core/business/utils
Class: ProductPriceUtils
Method : getFinalPrice

Design Smell Refactoring :

1). Extract Class

Path : sm-core-model/src/main/java/com/storemanager/core/model/common
Class : Criteria

2). Move Method

Path :sm-core/src/main/java/com/salesmanager/core/business/services/search
Class : SearchServiceImpl
Method : Config

3). Pull Up Variable

Path : sm-core/src/main/java/com/salesmanager/core/business/modules/integration/shipping/impl
Class : CustomWeightBasedShippingQuote

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud