Refactored code to remove design and implementation smells

[Hatim001]

Things Done -

Implementation smells refactoring:

1. Extract Method

   • File -> sm-shop/src/main/java/com/salesmanager/shop/utils/EnumValidator.java
   • Class -> EnumValidator
   • Method -> isValid

2. Decompose Conditional

   • File -> sm-shop/src/main/java/com/salesmanager/shop/store/controller/shoppingCart/facade/ShoppingCartFacadeImpl.java
   • Class -> ShoppingCartFacadeImpl
   • Method -> createCartItems

3. Rename method/variable

   • File -> sm-core/src/main/java/com/salesmanager/core/business/utils/DataUtils.java
   • Class -> DataUtils
   • Method -> getWeight

Design smells refactoring:

1. Pull-up method

   • File -> sm-core-model/src/main/java/com/salesmanager/core/model/common/description/Description.java
   • Class -> Description
   • Method -> Description

2. Extract Class

   • File -> sm-core/src/main/java/com/salesmanager/core/business/configuration/DataConfiguration.java
   • Class -> DataConfiguration
   • Method -> additionalProperties

3. Push-down method

   • File -> sm-core-model/src/main/java/com/salesmanager/core/model/common/Criteria.java
   • Class -> Criteria
   • Method -> setLegacyPagination

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information