search

shopkeep / pytest-black

pytest plugin to enable formatting checks with black
MIT License
53 stars 23 forks source link

Replace subprocess by click.testing.CliRunner #21

Closed maxbrunet closed 5 years ago

maxbrunet commented 5 years ago

I suggest this change to fix #20. This replaces subprocess by the click.testing.CliRunner.

Not perfect either though and not sure if we should worry much about that: :slightly_frowning_face:

These tools should really only be used for testing as they change the entire interpreter state for simplicity and are not in any way thread-safe!

https://click.palletsprojects.com/en/7.x/testing/

maxbrunet commented 5 years ago

Superseded by #23, thanks @chbrown and @iandotmartin!