search

shopkeep / pytest-black

pytest plugin to enable formatting checks with black
MIT License
53 stars 23 forks source link

Last commit breaks pytest-black under poetry #45

Closed tr11 closed 2 years ago

tr11 commented 4 years ago

The commit https://github.com/shopkeep/pytest-black/commit/584c2d1afde5f3c80027c0c2e093239aaed45c51 for pipenv support breaks existing installs with the poetry package manager. This is in all similar to the bug described in https://github.com/peterjc/flake8-black/issues/23, which is referenced from the pipenv issue listed on the commit.

As a workaround, one can do what's mentioned on https://github.com/peterjc/flake8-black/issues/23#issuecomment-635389218, but it would be great if one can just install pytest-black as before the commit above.

paddycarey commented 4 years ago

Hi @tr11 thanks for the report.

This is somewhat frustrating, it seems we can support either pipenv or poetry, but not both at the same time until black releases a non-prerelease version. I'm inclined to leave the versioning as-is and add the same workaround note to the README as in the linked flake8-black issue.

I'll try to get to this soon, but happy to accept a PR with the updates too.

tr11 commented 4 years ago

@paddycarey, I'll submit a PR this weekend to add the info to the readme. Thanks!