shopozor / ci

Jelastic configuration of our continuous integration infrastructure.
0 stars 0 forks source link

The Jenkins environment needs to be secured #15

Open zadigus opened 5 years ago

zadigus commented 5 years ago

We need to protect the environment with https protocol. This needs to happen in our manifest.

zadigus commented 5 years ago

https://stackoverflow.com/questions/56124771/how-to-close-docker-environment-from-the-outside-world/56130045#56130045

zadigus commented 5 years ago

After discussions with @shikamu, it turns out it's not necessary to secure this environment with https. It would be better but it is not extremely necessary. The importance of this issue is therefore very low.

zadigus commented 4 years ago

https://www.studytonight.com/jenkins/securing-jenkins

zadigus commented 4 years ago

The stuff we tried to integrate last Nov 15 2019 is now working with the jps manifest.

zadigus commented 4 years ago

There's also the following code to activate in ssl.conf

location / {

we need a domain name for this:

    #proxy_set_header Strict-Transport-Security "max-age=63072000; includeSubDomains; preload";
zadigus commented 4 years ago

ssl on tu mets plus par exemple tu mets tout sur la ligne du listen il me semble, genre listen 443 http2 ssl; mais moi jte propose de faire la chose suivante: 1) tu fais ton bordel avec let's encrypt pour qu'il nous ponde le certificat 2) après osef de la config qu'il nous génère, on prend notre config et on injecte juste son certificat et ça ça doit marcher ya juste un truc qu'il faudrait encore intégrer au jps ça peut être fait n'importe quand mais avant de restart nginx: faut lancer cette commande: openssl dhparam -out /etc/nginx/dhparam.pem 4096

le chemin peut être changé mais après faut changer le ssl.conf, on a cette ligne: ssl_dhparam /etc/nginx/dhparam.pem; ça peut prendre 2-3 minutes pour exécuter la commande

shikamu commented 4 years ago

@shikamu (note to self), look at https://github.com/eclipse/jetty.project/issues/4247 there seems to be information about the samesite cookie thing. The server that we are running jenkins on is jetty server.