shoppingflux / shoppingfluxexport

7 stars 7 forks source link

Deleting a carrier in PrestaShop used in ShoppingFlux is wrongly impacting the configuration #386

Closed ghost closed 6 years ago

ghost commented 6 years ago

Expected behaviour

After deleting a carrier in PrestaShop which was selected in the configuration of ShoppingFlux as a match, the configuration should then show somehow a mismatch.

Actual behaviour

After deleting a carrier in PrestaShop which was selected in the configuration of ShoppingFlux as a match, the configuration is showing another carrier in the dropdown which is not however NOT selected.

Therefore, the user might think this carrier is selected, which is not the case.

This is now fixed by saving again the configuration, which will then apply the carrier appearing in the dropdown. It's however not a solution. The user should be somehow notified in the configuration page that there is a mismatch when no "selected" carrier is found.

Steps to reproduce the behaviour

1 - Select the carrier XYZ in the module's configuration as a match 2 - Delete the carrier from PrestaShop 3 - Go back in the module configuration, another carrier appear as selected (but is not really selected) 4 - Wait for the next order, the old carrier will be selected at the opposite of what the configuration in the module might show

Note : What will be applied should not change the behavior of how carriers are selected for orders.

ghost commented 6 years ago

We should find a solution to display the error message. Maybe a global error in BO.