search

shopware / SwagExtensionStore

The integrated Shopware Store for Shopware 6
2 stars 2 forks source link

NEXT-34371 - Add promotion banner for statistics module #7

Closed adrianles closed 5 months ago

adrianles commented 7 months ago

Design and texts of the banner are not final.

The banner will be shown when the StatisticsService app is not installed.

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 60.03%. Comparing base (a284644) to head (6f8156e).

Files Patch % Lines
...pp/administration/src/module/sw-dashboard/index.js 0.00% 2 Missing :warning:
...sion-store/service/extension-store-data.service.js 0.00% 1 Missing and 1 partial :warning:
...inistration/src/module/sw-extension-store/index.js 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #7 +/- ## ============================================ - Coverage 68.00% 60.03% -7.97% ============================================ Files 19 17 -2 Lines 700 573 -127 Branches 102 107 +5 ============================================ - Hits 476 344 -132 - Misses 196 200 +4 - Partials 28 29 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adrianles commented 7 months ago

We cannot merge this MR yet

adrianles commented 6 months ago

If the user doesn't have permission to access the extension store (system.plugin_maintain). We need to prevent from doing an XHR request to the store to get the appId (this is done in order to be able to generate the link to the app detail page). Instead we will create a link to the extension store (once the user gets rediected there he will see a message that says Access denied. Looks like you don’t have permission to access this page. Reach out to an administrator to gain access.).

adrianles commented 6 months ago

add some colors via meteor tokens https://www.npmjs.com/package/@shopware-ag/meteor-tokens

edit: In the end we decided against it. We added the color hex directly.

frobel commented 6 months ago

During the QA we found:

adrianles commented 5 months ago

During the QA we found:

* If a user without permission login and follow the link in the dashboard (to the app) they will redirected to a access denied page. If the user logout and you login with a user (same session and cookies) which have access to the app, they will redirected to the app listing and NOT as expected to the StatisticsApp

* If a user install the app and open the dashboard after the installation, the promotion banner is still visible. The expectation would be that the promotion banner is gone and the consent banner or nothing is shown (depend on the consent state)

* in SaaS the promotion banner is still visible in the extension store. On the dashboard the promotion banner is hided. The expectation is: Dashboard and Extension Store in SaaS don't have a promotion banner.

First point is fixed by the ct-admin team (NEXT-35903).

Third point is not relevant in Github (it was fixed internally anyway).

adrianles commented 5 months ago

we can merge it now